If the clock timer fires when global scr is NULL then we end up calling
redrawmenubar() with a NULL global scr, but a valid local scr.
So just pass in the scr used when doing "stuff" into redrawmenubar(),
making the 'scr' in redrawmenubar() also local scope.
This is the beginning of adding some battery display support into the menu and figuring out how to add arbitrary widgets into the menu bar.
It's going to take a bunch more commits / time to clean this up to be more flexible, but at least now we have an MVP of adding a new "thing", buggy as it is.
* add a batteryinfo config option to enable whether or not to display
the current battery info string
* populate that battery info string whenever we receive a battery
update from the module
* document it all
This is very specific to a battery thing rather than a generic menu
widget thing, but I think I'll go and twiddle with this stuff a bit
more first and then work on a more generic "menu widget" thing later.
It'd be nice to have "menu bar things" like battery and the date/time
field on a linked list of "things".
There's also some bugs - notably, rendering artifacts when the
string length shrinks, and it only updating on the 'current' menu bar
(when you have multiple desktops visible at once.) Those also
should be fixed for completeness. :-)
Tie into the periodic function so we can get the APM info.
For now it's not checking that some time has elapsed, the hope
is that it'll just be driven by md_main_loop() / 5 second select
timeout.
* add a basic select() loop for the read FD to see if it's ready
* optionally block in md_read() even if we timeout - this is used for
the md_command() side of things
* md_handle_input() however doesn't block and will happily timeout
so the loop can run and the periodic function can run.
This indeed seems to work. It's a bit dirty, but it at least stops
the main loop from being fully blocking and that's super useful for
modules that wish to schedule background work.
* Yeah it'd be nice to just use libevent here, alas
* Figure out how all the reading/writing works and comment it
* Add a periodic function that'll be called every trip through
the main loop; will turn it into something more formally periodic
later.
There's still lots to do here before I can actually schedule
periodic events and the read()s are non-blocking. Give it time!
Totally not ready for prod, but at least I'm making progress
figuring out how to add extra bits to this thing.
* add a second widget to the menu bar, next to the title bar
* add a new module command to update the battery information
* add a freebsd specific Battery module, not linked into the
build right now.
* amiwm will print out whenever we get battery information from the
module.
Right now I'm trying to figure out how to get some kind of periodic
background event into the module main loop. Launcher does it
using cx_broker(), but I dunno if I can adapt that pattern here.
Marcus had written up workbench style widgets inside the two external
helper programs requestchoice and executecmd. This ports the code over
to libami.
Note that there isn't a generic gadget or collection of gadgets yet -
this is purely a refactor of the code, and the upcoming commit that
migrates requestchoice/executecmd over to use them just handles them
directly via xlib like they have always done.
This adds a command to iterate over the set of windows. It's not
like alt-tab in ye olde windows world where you'd alt tab once to
switch between two windows, and then keep alt-tab'ing with alt down
to go through the window list. For now it just literally iterates
through those windows.
This makes it a lot easier to work with a large number of open
windows without having to constantly use the mouse.
This is a pretty straight forward change to remove the global front
variable and instead use a couple of accessor functions.
This hopefully will make it easier to keep track and debug when
the front screen changes.
* ensure newly created windows are placed somewhere visible - ie, not
off the screen.
* ensure newly created window sizes aren't insanely large, which end up
being unable to be moved or resized in amiwm.
This has shown up with gtk apps (kicad, firefox) with their load/save
dialog. For some reason they want to be almost 2x my desktop size,
making them super hard to use.
Although it likely doesn't matter /that/ much, the x11 xlib manual
does say to use it rather than expecting the struct to stay the same
size.
Yeah yeah it's 2022 and we really do build things from source,
ICCCM is likely not going to change that much nowdays, etc, etc.
